Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell language support #738

Merged
merged 88 commits into from Feb 16, 2022
Merged

Add shell language support #738

merged 88 commits into from Feb 16, 2022

Conversation

calebkiage
Copy link
Contributor

No description provided.

@baywet baywet changed the base branch from main to feature/url-template October 21, 2021 17:47
baywet
baywet requested changes Oct 25, 2021
View reviewed changes
src/Kiota.Builder/Refiners/ShellRefiner.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Refiners/ShellRefiner.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Refiners/ShellRefiner.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Refiners/ShellRefiner.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/Shell/ShellCodeClassDeclarationWriter.cs Outdated Show resolved Hide resolved
Base automatically changed from feature/url-template to main October 27, 2021 12:21
@calebkiage calebkiage changed the title WIP: Add shell writer Add shell language support Nov 10, 2021
@calebkiage calebkiage marked this pull request as ready for review November 10, 2021 15:54
baywet
baywet previously approved these changes Feb 16, 2022
View reviewed changes
src/Kiota.Builder/Writers/Shell/ShellCodeMethodWriter.cs Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking in the last minute changes

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

83.2% 83.2% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 980a070 into main Feb 16, 2022
@baywet baywet deleted the feat/cli_generator branch February 16, 2022 15:22
@baywet
Copy link
Member

baywet commented Feb 16, 2022

🍾🥳🙌🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
CLI Work to support generating CLIs with Kiota
Projects
None yet
Milestone
Community Preview
Development

Successfully merging this pull request may close these issues.

Kiota CLI Generation Support
2 participants
@calebkiage @baywet