Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe usage of PyYAML yaml.load() (Related to CVE-2017-18342) #136

Closed
dgarrett-microsoft opened this issue Feb 6, 2019 · 2 comments · Fixed by #137
Closed

Unsafe usage of PyYAML yaml.load() (Related to CVE-2017-18342) #136

dgarrett-microsoft opened this issue Feb 6, 2019 · 2 comments · Fixed by #137
Milestone
Knack 0.7.0

Comments

@dgarrett-microsoft
Copy link

Default behavior of PyYAML's yaml.load() method is unsafe and can execute code in yaml files.
safe_load() should be used instead: yaml/pyyaml#193 (comment)

Related CVE-2017-18342: https://nvd.nist.gov/vuln/detail/CVE-2017-18342
@tjprescott tjprescott added this to the Knack 0.6.0 milestone Feb 6, 2019
derekbekoe added a commit to derekbekoe/knack that referenced this issue Feb 11, 2019
@derekbekoe
Use yaml.safe_load to fix microsoft#136
0143814
@derekbekoe derekbekoe mentioned this issue Feb 11, 2019
Merged
tjprescott pushed a commit that referenced this issue Feb 11, 2019
@derekbekoe @tjprescott
Use yaml.safe_load to fix #136 (#137)
1484885
@derekbekoe
Copy link
Contributor

@dgarrett-microsoft A fix was pushed to use yaml.safe_load - https://github.com/Microsoft/knack/releases/tag/v0.5.2

@dgarrett-microsoft
Copy link
Author

Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Knack 0.7.0
Development

Successfully merging a pull request may close this issue.

Use yaml.safe_load derekbekoe/knack
3 participants
@tjprescott @derekbekoe @dgarrett-microsoft