Fix parsing of boolean type #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
swannman
approved these changes
Dec 8, 2020
starix
added a commit
to starix/krabsetw
that referenced
this pull request
Dec 9, 2020
Fix parsing of boolean type (microsoft#148)
swannman
added a commit
that referenced
this pull request
Oct 8, 2021
This was referenced Oct 8, 2021
swannman
added a commit
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception "Property size doesn't match requested size" rise if we try to query bool value from TDH_INTYPE_BOOLEAN field.
Example of code:
if (prop.type() == TDH_INTYPE_BOOLEAN) val = parser.parse<bool>(prop.name());Note, if we try to query TDH_INTYPE_BOOLEAN as BOOL (or any other 4-byte type) function parse() rise another exception "Attempt to read property 'XXX' type BOOLEAN as INT32"