You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently lage only gives a package graph and task graph separately, so task-scheduler doesn't know when some packages do not contain the tasks in the package.json.
Because of how the final combined package-task is generated, we might over-aggressively run tasks because of this missing info.
For example, if A depends on B and B depends on C:
A -> B -> C
and if only C has the task of special-C-build, when this following is called:
lage special-C-build --scope A
Nothing should be run because "A" doesn't have that task. The expected result is that nothing is run.
The text was updated successfully, but these errors were encountered:
I am planning to add following argument to createPipeline function exported by task-scheduler
canRunTaskInPkg: (taskName: string, packageName: string) => boolean
Since lage has workspace knowledge and knows about scripts in individual packages, i think its better if we pass callback to task-scheduler which can tell if a particular package contains a particular script.
Task - scheduler while generating task graph can use this function to decide if it wants to put things in queue.
From lage, we can easily create canRunTaskInPkg from workspace object
Currently lage only gives a package graph and task graph separately, so task-scheduler doesn't know when some packages do not contain the tasks in the package.json.
Because of how the final combined package-task is generated, we might over-aggressively run tasks because of this missing info.
For example, if A depends on B and B depends on C:
A -> B -> C
and if only C has the task of
special-C-build
, when this following is called:lage special-C-build --scope A
Nothing should be run because "A" doesn't have that task. The expected result is that nothing is run.
The text was updated successfully, but these errors were encountered: