Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--grouped truncates long build output #114

Open
ecraig12345 opened this issue Nov 20, 2020 · 2 comments
Open

--grouped truncates long build output #114

ecraig12345 opened this issue Nov 20, 2020 · 2 comments
Assignees

Comments

@ecraig12345
Copy link
Member

With the --grouped option and a task with very long output, some of the output is getting truncated (at least on errors). This is a problem because it can make determining the source of an error impossible--2 examples in this build. I've disabled grouped builds in Fluent UI for now (microsoft/fluentui#16019) so that we can actually debug these issues, but I'd like to re-enable the option since it's a better experience in general.

@kenotron
Copy link
Member

kenotron commented Feb 4, 2021

The problem also with --grouped is that it buffers... so if things are timed out, the log would actually never be written. I think if the log is supposed to be long, maybe turning it off is good enough? What do you think?

@ecraig12345
Copy link
Member Author

Yeah turning it off is how we've worked around the issue so far. Some other ideas:

  • Can we make lage detect when it's about to be killed and flush the logs?
  • Maybe add a way to turn off grouping per project? (though for occasional weird issues or PRs that introduce new hangs, that wouldn't help)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants