Disable grouped build output and fix the build issue #16019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
approved these changes
Nov 20, 2020
xugao
approved these changes
Nov 20, 2020
|
Hello @ecraig12345! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 54 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msft-github-bot merge this in 1 minute |
|
Hello @ecraig12345! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cbf024f:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: f1c0db2 Possible causes
Recommendations
|
ecraig12345
requested review from
assuncaocharles,
jurokapsiar,
layershifter,
ling1726,
miroslavstastny and
pompomon
as code owners
ecraig12345
changed the title
|
This is the error: I suspect this issue's sudden appearance has to do with today's release of I'm going to try and find a workaround to unblock builds, but @miroslavstastny or @layershifter should look into this and figure out the right longer-term fix. Full log output: |
|
Figured out the issue: for some reason |
ling1726
approved these changes
Nov 20, 2020
joschect
approved these changes
Nov 20, 2020
ecraig12345
force-pushed
the
no-grouped
branch
from
f98f998
to
cbf024f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is causing part of the output for some build tasks (which have especially long output) to be eaten, which makes it hard to debug errors. 2 examples here... I suspect this has something to do with
lage's--groupedflag, so trying out removing it as a workaround.Update: removing grouped build output revealed the real issue, which was in the
create-react-apptest inprojects-test. This error seems to be caused by a change intypescript@4.1.2which was released today, so update the test script to temporarily downgrade the test project's TS version.