-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to invalidate all providers using a single server -> client request. #1163
Comments
I don't entirely understand the idea. Is the idea now that the server should be responsible for invalidating code lenses / semantic tokens / collected code actions ? Because right now, from what I gather from the spec, the client is responsible for deciding when that stateful information is stale. |
Aha, I notice now there's a new proposed request |
There are situation where a client can not detect that (e.g. a project configuration file changes). So in these cases a server needs to ask the client to refresh everything. |
Interesting observation: today in practice rust-analyzer fiers both updates.mp4 |
@matklad IMO you should file an issue for this against VS Code. If two files are side by side IMO VS Code should pull for semantic tokens with high frequency for the active file and for a lower frequency on the other files. |
Done: microsoft/vscode#130486! |
Currently the are separate methods to invalidate semantic tokens and code lens. Would be good to have one request to invalidate them all since a project wide change usually forces an update of all providers.
The text was updated successfully, but these errors were encountered: