Recommend relationship between error ranges and selections for quickfixes #1897
Comments
|
If #1897 is implemented, then ideally the same recommendation should apply there. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this issue
Feb 20, 2024
Summary: Here we're a bit more restrictive about when we show quickfixes: https://pxl.cl/4kgXh Before this change, we also showed quickfixes when the selection contained the error span: https://pxl.cl/4kh51 With this change, we remove cases where we would show a quickfix but neither TypeScript nor Rust Analyzer would. ## Future Work VSCode language experiences are not consistent in how they decide whether to show a quickfix: I saw different behavior in TypeScript and Rust Analyzer, for example. We're asking for guidance on this LSP issue: microsoft/language-server-protocol#1897 Reviewed By: ljw1004 Differential Revision: D53568626 fbshipit-source-id: fe3ba85c19bd96fd491c60f362e8b0a17a1f2199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given an error range and a selection range, when should we show the error? There are some choices:
A: overlap and selection is multi-character
B: error contains selection and selection is multi-character
C
D
E: error overlaps with selection (inclusive) and selection is single-character
F: error overlaps with selection (inclusive) and selection is single-character
It would be nice if languages were consistent, so at least a recommendation would be most welcome!
The text was updated successfully, but these errors were encountered: