Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make range optional in Diagnostic #249

Closed
smarter opened this issue May 21, 2017 · 3 comments
Closed

Make range optional in Diagnostic #249

smarter opened this issue May 21, 2017 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@smarter
Copy link
Contributor

smarter commented May 21, 2017

Currently, the range in a diagnostic cannot be omitted: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#diagnostic. However, in some cases a compiler might not give range information for a diagnostic, for example if the information comes from code where the compiler did not track the position for some reason, or if the diagnostic is not specific to any position (e.g., "The compiler crashed with stack trace ...", "The compiler was run with the invalid flag ..."). While this information should not be displayed in the text area of the client, most editors provide a list of all diagnostics somewhere where this information could appear.

@mickaelistria
Copy link

mickaelistria commented May 22, 2017 via email

@rictic
Copy link
Contributor

rictic commented May 23, 2017

There's also cases where the file is known but the position in the file isn't.

@dbaeumer
Copy link
Member

I will mark this as a dup of #256

@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants