Harden IDE, 2nd attempt #2692
Merged
Harden IDE, 2nd attempt #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They used to crash when applied to NoPosition. We now handle this case gracefully.
This happens, e.g. in realApply in Applications. Change TreeAccumulator and TreeMap to survive on untyped tree nodes in error cases. Also, add a configurable check that typed nodes point to untyped ones only in error cases.
Seems to happen in several scenarios. For now, ignore, so that we can get real work done in the IDE. Ignoring is configurable, we can turn it off if we want to hunt down problems.
Avoids repeated crashes when hitting a tree that exists only in untyped form.
Closed
smarter
reviewed
Jun 6, 2017
| @@ -14,4 +15,7 @@ class InteractiveCompiler extends Compiler { | |||
| override def phases: List[List[Phase]] = List( | |||
| List(new FrontEnd) | |||
| ) | |||
|
|
|||
| override def rootContext(implicit ctx: Context) = | |||
| super.rootContext.fresh.addMode(Mode.Interactive) | |||
There was a problem hiding this comment.
There's also Mode.ReadPositions that we always need in the IDE, it's currently set in InteractiveDriver but could be moved here.
smarter
reviewed
Jun 6, 2017
| /** Configurable: Accept stale symbol with warning if in IDE */ | ||
| def acceptStale(denot: SingleDenotation): Boolean = | ||
| (mode.is(Mode.Interactive) && Config.ignoreStaleInIDE) && { | ||
| ctx.warning(denot.staleSymbolMsg) |
There was a problem hiding this comment.
Such a warning will popup in the IDE (not currently because we ignore warnings without positions, but that's just because of an issue in the LSP (microsoft/language-server-protocol#249)), maybe use ctx.debug instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On stale symbols: There are legitimate scenarios how they can arise in the IDE.
For instance, we define a class, refer to it, edit the class definition and introduce errors. The class symbol temporarily no longer exists until the errors are fixed. But typed trees elsewhere will refer to it. That's why StaleSymbol errors now give warnings by default. A config option can turn them back into exceptions, which is useful if we want to find the root cause of a particular warning.