Skip to content

Commit

Permalink
[dask] remove 'client' kwarg from fit() and predict() (fixes #3808) (#…
Browse files Browse the repository at this point in the history
…3883)

* starting on Dask client

* more docs stuff

* fix pickling

* just copy docstrings

* fit docs

* switch test order

* linting

* use client kwarg

* remove inner set_params()

* add type hints

* fix type hints

* remove commented code

* reorder

* fix tests, add client_ property

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* fix tests

* linting

* simplify

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
  • Loading branch information
jameslamb and StrikerRUS committed Feb 3, 2021
1 parent 56fc036 commit c3ac77b
Show file tree
Hide file tree
Showing 3 changed files with 601 additions and 42 deletions.
2 changes: 1 addition & 1 deletion .ci/test.sh
Expand Up @@ -95,7 +95,7 @@ if [[ $TASK == "swig" ]]; then
exit 0
fi

conda install -q -y -n $CONDA_ENV dask distributed joblib matplotlib numpy pandas psutil pytest scikit-learn scipy
conda install -q -y -n $CONDA_ENV cloudpickle dask distributed joblib matplotlib numpy pandas psutil pytest scikit-learn scipy

# graphviz must come from conda-forge to avoid this on some linux distros:
# https://github.com/conda-forge/graphviz-feedstock/issues/18
Expand Down

0 comments on commit c3ac77b

Please sign in to comment.