Add support for platform specific modules. #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 10, 2022
|
It would be great, if it can be split to two commits. They can be in the same PR. |
cwize1
commented
Jan 10, 2022
Manually import all the mix-in modules, instead of dynamically importing everything. This will allow for platform if statements over the import statements of platform specific modules.
Allow extensions to specify a single python file instead of only supporting importing an entire directory. An extension can use this to import a file that handles any custom import rules they have, such as using platform if statements.
cwize1
force-pushed
the
user/chrisgun/Platform
branch
from
ebd5fbf
to
12cdf5d
Compare
Done. |
cwize1
force-pushed
the
user/chrisgun/Platform
branch
from
12cdf5d
to
91220a9
Compare
cwize1
force-pushed
the
user/chrisgun/Platform
branch
from
91220a9
to
ebf9643
Compare
squirrelsc
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually import all the mix-in modules, instead of
dynamically importing everything. This will allow for
platform
ifstatements over theimportstatementsof platform specific modules.
Allow extensions to specify a single python file
instead of only supporting importing an entire
directory. An extension can use this to import a
file that handles any custom import rules they have,
such as using platform
ifstatements.Improve sub-class not found exception message.