Add serial console support to QEMU orchestrator. #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add support for libvirt event callbacks. Libvirt requires setting up a single process-wide event loop for handling the events. This change provisions a separate Python thread for this purpose. 2. Create a reader for the libvirt console stream that writes the console output to file. (Ideally we would use the inbuilt libvirt support for writing the console to file. But SELinux doesn't like this for whatever reason.) This mimics the Azure API that provides the serial console output as a log that can be downloaded. 3. Implement the orchestrator serial console feature. This just reads and dumps the console log file. 4. Fix a minor bug in NodeSpace schema class, that causes a crash for some runbook configurations.
squirrelsc
reviewed
Jan 22, 2022
squirrelsc
reviewed
Jan 22, 2022
cwize1
force-pushed
the
user/chrisgun/QemuConsole2
branch
from
8aa9205
to
dda5092
Compare
squirrelsc
reviewed
Jan 25, 2022
| node_capabilities = schema.NodeSpace() | ||
| node_capabilities.name = "QEMU" | ||
| node_capabilities.node_count = 1 | ||
| node_capabilities.core_count = 2 |
There was a problem hiding this comment.
Make sure the deployment phase will use those values.
squirrelsc
reviewed
Jan 25, 2022
| node_capabilities.memory_mb = 4096 | ||
| node_capabilities.disk = schema.DiskOptionSettings() | ||
| node_capabilities.network_interface = schema.NetworkInterfaceOptionSettings() | ||
| node_capabilities.network_interface.max_nic_count = 1 |
There was a problem hiding this comment.
It needs to set nic_count too. the max_nic_count is used to limited how many nics can be created in some cases, which hot add nics.
squirrelsc
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for libvirt event callbacks. Libvirt requires
setting up a single process-wide event loop for handling the
events. This change provisions a separate Python thread for
this purpose.
Create a reader for the libvirt console stream that writes
the console output to file. (Ideally we would use the inbuilt
libvirt support for writing the console to file. But SELinux
doesn't like this for whatever reason.) This mimics the Azure
API that provides the serial console output as a log that can
be downloaded.
Implement the orchestrator serial console feature. This
just reads and dumps the console log file.
Fix a minor bug in NodeSpace schema class, that causes
a crash for some runbook configurations.