Bug fixes for some tier 1 tests for CBL-Mariner on QEMU. #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romoh
reviewed
Jan 28, 2022
romoh
previously approved these changes
Jan 28, 2022
squirrelsc
reviewed
Jan 28, 2022
squirrelsc
reviewed
Jan 28, 2022
squirrelsc
reviewed
Jan 28, 2022
squirrelsc
reviewed
Jan 28, 2022
and so should share the package handling logic, it is not a derivative of Fedora and has substantial differences. Hence, the RPM handling logic was split off into a new base class that both `Fedora` and `CBLMariner` classes inherit from. 2. Fix a few tests that didn't declare their required `supported_features`. 3. Restrict tests that rely on VMBus to the `AZURE` platform. (When the Hyper-V support is added, it can be added as a platform to these tests as well.) 4. Add support for CBL-Mariner to Docker tool.
cwize1
force-pushed
the
user/chrisgun/TestFixes3
branch
from
920dffd
to
ce2b348
Compare
squirrelsc
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OS type for CBL-Mariner. While CBL-Mariner uses RPM
and so should share the package handling logic, it is not
a derivative of Fedora and has substantial differences.
Hence, the RPM handling logic was split off into a new
base class that both
FedoraandCBLMarinerclassesinherit from.
Fix a few tests that didn't declare their required
supported_features.Restrict tests that rely on VMBus to the
AZUREplatform.(When the Hyper-V support is added, it can be added as a
platform to these tests as well.)
Add support for CBL-Mariner to Docker tool.