find_partition_with_freespace: refactor function to hoist to node level #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsrivastavv
reviewed
Feb 14, 2022
squirrelsc
reviewed
Feb 14, 2022
squirrelsc
approved these changes
Feb 14, 2022
lesscodingmorehappiness
pushed a commit
that referenced
this pull request
Feb 15, 2022
…el (#1743) * refactor find_partition_with_freespace and hoist to node level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@somil55 added a function find_partition_with_freespace to the nested virt test suite and it looks super useful. Let's hoist it!
This PR:
check_partition_sizebecomes a public function of the Df tool, since it depends on that tool to perform it's check.The end result is that the caller can use
node.find_partition_with_freespace(size_in_gb)