Chown Tool: remove broken shell.chown and replace with node.tools[Chown] #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testing on ovs-rh branch... |
|
Testing looks good, opening for review |
mcgov
force-pushed
the
mcgov/chown
branch
3 times, most recently
from
87a2fd7
to
d7ac69e
Compare
|
fixed weird logic for user:group. You can use :group by itself and neither user nor group is a required argument according to the docs |
squirrelsc
reviewed
Feb 15, 2022
squirrelsc
reviewed
Feb 15, 2022
squirrelsc
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell.chown is broken, replace it with a tool for posix systems.