-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fcopy related cases for Check-FileInLinuxGuest command #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments added, thank you for the improvements!
@@ -32,6 +32,17 @@ $gsi = $null | |||
# Main body script | |||
# | |||
####################################################################### | |||
|
|||
# Read parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you add TestParams parsing directly to Main, then this section is no longer required.
Please check sample code here:
https://github.com/LIS/LISAv2/blob/master/Testscripts/Windows/SETUP-Remove-NVME-Disk.ps1#L48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your guidance, new method is very convenient.
191fea0
to
5c1d39e
Compare
Add new changes here, maybe better put the new change to new commit.
|
@lixuemin2016 @chvalean please follow up the change if needed further discussion. Or, sign off please. |
Original Check-FileInLinuxGuest has bugs when migration from lis-test to lisav2.
Details update lists as below:
$sts = Run-LinuxCmd -username $VMUserName -password $VMPassword -port $VMPort -ip $Ipv4 "rm -f /mnt/test/$testfile" -runAsSudo
Have run all the TestTag fcopy cases, all the cases are passed. Before update, FCOPY-REPEATED-DELETE and FCOPY-OVERWRITE failed.
Thank you so much.