Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex match IB NICs #1927

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

kamalca
Copy link
Collaborator

@kamalca kamalca commented Apr 28, 2022

Recent changes to the ip show regex made IB devices no longer show up in node.nics.

@kamalca
Copy link
Collaborator Author

kamalca commented Apr 28, 2022

@squirrelsc What was the goal of the last change for this regex expression? Was it important to match only ethernet devices?

@kamalca
Copy link
Collaborator Author

kamalca commented Apr 28, 2022

Example Output:
6: ib0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc mq state UP group default qlen 256
link/infiniband 00:00:09:27:fe:80:00:00:00:00:00:00:00:15:5d:ff:fd:33:ff:7f brd 00:ff:ff:ff:ff:12:40:1b:80:76:00:00:00:00:00:00:ff:ff:ff:ff
inet 172.16.1.118/16 brd 172.16.255.255 scope global ib0
valid_lft forever preferred_lft forever
inet6 fe80::215:5dff:fd33:ff7f/64 scope link
valid_lft forever preferred_lft forever

lisa/nic.py Outdated Show resolved Hide resolved
@squirrelsc
Copy link
Member

link/infiniband 00:00:09:27:fe:80:00:00:00:00:00:00:00:15:5d:ff:fd:33:ff:7f brd 00:ff:ff:ff:ff:12:40:1b:80:76:00:00:00:00:00:00:ff:ff:ff:ff
inet 172.16.1.118/16 brd 172.16.255.255 scope global ib0
valid_lft forever preferred_lft forever
inet6 fe80::215:5dff:fd33:ff7f/64 scope link

It fixed an '\n' is not optional, so it's failed in some formats. But the original one doesn't like to include infiniband.

@kamalca kamalca force-pushed the kameroncarr/improve-ib-pingpong branch from 8ecc02b to 151ebf9 Compare April 29, 2022 22:54
Recent changes to the ip show regex made IB devices no longer show up in node.nics.
@kamalca kamalca force-pushed the kameroncarr/improve-ib-pingpong branch from 151ebf9 to 6347aa4 Compare April 29, 2022 23:38
@squirrelsc squirrelsc merged commit 3938ad8 into microsoft:main Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants