Fix serial disk add testcase logic

[SRIKKANTH]

Current logic is adding and removing a single disk instead of adding 1 disk at a time till max supported disks.

Modified the logic to add 1 disk at a time till max allowed disks and for removal all attached disks one after the other.

[LiliDeng]

Current logic is adding and removing a single disk instead of adding 1 disk at a time till max supported disks.

Modified the logic to add 1 disk at a time till max allowed disks and for removal all attached disks one after the other.

Is there any test issue for current code? Can you clarify the reason for changing code? Thanks.

[SRIKKANTH]

Current logic is adding and removing a single disk instead of adding 1 disk at a time till max supported disks.
Modified the logic to add 1 disk at a time till max allowed disks and for removal all attached disks one after the other.

Is there any test issue for current code? Can you clarify the reason for changing code? Thanks.

Current testcase simply verifies adding removing a single disk instead of actually checking if its allowed to attach one disk at a time till max supported disks.

Is this expected behavior?

If yes why the add remove iteration count is equal to max disks allowed on the SKU why not add remove with a fixed number of times.

I think we should validate adding disks serially till max allowed disks and remove all the attached disks in the end.

[adityagesh]

Your change aligns with the description of the test case (pasting it below)

        1. Get maximum number of data disk for the current vm_size.
        2. Get the number of data disks already added to the vm.
        3. Serially add and remove the data disks and verify that the added
        disks are present in the vm.

However, the name of the function is misleading, how about renaming it similar to something like hot_add_disk_serial_one_by_one? Similar to how we have for the nic

Thoughts on this? @LiliDeng