Add Image Feature Requirements #3255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalca
force-pushed
the
kameroncarr/image-features
branch
8 times, most recently
from
b57517c
to
65dfcd5
Compare
squirrelsc
reviewed
Apr 9, 2024
squirrelsc
reviewed
Apr 9, 2024
kamalca
force-pushed
the
kameroncarr/image-features
branch
3 times, most recently
from
8627bf6
to
91c93f3
Compare
|
@LiliDeng Do you have a Community Gallery Image I can test my changes on? |
squirrelsc
reviewed
Apr 23, 2024
community_gallery_image: "southcentralus/FreeBSDCGTest-d8a43fa5-745a-4910-9f71-0c9da2ac22bf/FreeBSD-14.0-RC3-amd64-ufs-gen1-testing/latest" please specify the location southcentralus |
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
91c93f3
to
8600acc
Compare
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
8600acc
to
707e9af
Compare
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
707e9af
to
a5c7e71
Compare
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
squirrelsc
reviewed
Apr 24, 2024
kamalca
force-pushed
the
kameroncarr/image-features
branch
8 times, most recently
from
1ce4911
to
b081dce
Compare
Each feature can now implement a function `create_image_requirement` to determine a requirement based on the raw_capabilities of the image. The requirement is then merged with the platform requirement.
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
b081dce
to
d929fc8
Compare
squirrelsc
reviewed
Apr 29, 2024
squirrelsc
reviewed
Apr 29, 2024
squirrelsc
reviewed
Apr 29, 2024
kamalca
force-pushed
the
kameroncarr/image-features
branch
3 times, most recently
from
0ae8006
to
d929fc8
Compare
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
d929fc8
to
751e829
Compare
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each feature can now implement a function
create_image_requirementto determine a requirement based on the raw_capabilities of the image. The requirement is then merged with the platform requirement.