Include templog in LisaException message for Wget #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testcase verify_hpc_over_sriov calls Infiniband's method install_ofed() which in turn calls Wget's method get().
install_ofed() looks for "404: Not Found." error and if that string is present in the Exception message, it goes ahead and skips the testcase by raising UnsupportedDistroException. However the "404: Not Found." string is captured in the temp_log variable which was not being passed when LisaException was raised in the get() method of Wget and that's why the testcase got failed instead of getting skipped
As part of this PR, I have included temp_log as well, because install_ofed() is designed to look for that error which is in temp_log variable
This change is tested with:
redhat rhel 9_3 9.3.2024022812
redhat rhel 90-gen2 9.0.2024021412
oracle oracle-linux ol93-lvm 9.3.2
suse sles-15-sp5 gen1 2024.02.07