-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample package-lock fixes & migration to vite for react samples #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the samples, especially react-media-template, tested in Teams?
Please share any screen shot of sample running in Teams.
Sure, I just tested in Teams with Ngrok, and actually found a quirk with how ngrok and vite work. I had to add a new start-https command which basically lets Vite work with https during hot reloading. For localhost, start works just fine. This has no impact on blob deployments. I've also updated the README with this info and will investigate ways to remove this requirement. Note: this only impacts the React samples. |
In this pull request, I've addressed numerous issues with the samples that stem from package-lock files that included references to private npm feeds as well as dependencies that aren't actually in package.json files. Here are the changes included in this PR:
To make sure this doesn't cause any regressions, I tested each sample using npm run start and npm run build, both in each individual sample and from the root directory. Each appears to be working as expected!