Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor jumps during live share session #1788

Closed
lifeiscontent opened this issue Mar 9, 2019 · 6 comments
Closed

Cursor jumps during live share session #1788

lifeiscontent opened this issue Mar 9, 2019 · 6 comments

Comments

@lifeiscontent
Copy link

lifeiscontent commented Mar 9, 2019

Product and Version [VS/VSCode]: Version 1.32.1 (1.32.1)
OS Version [macOS/Windows]: 10.14.3 (18D109)
Live Share Extension Version: 0.3.1284
Target Platform or Language [e.g. Node.js]: OSX / JavaScript (Create React App)

Steps to Reproduce / Scenario:

  1. Create a session
  2. Share some ports from Create React App
  3. Take turns changing code
  4. Watch cursor jump around and screw up your code.
@lostintangent
Copy link
Member

lostintangent commented Mar 9, 2019

@lifeiscontent Thanks for reporting this! For step #2, did you manually share the ports, or did you just run “npm start” (and the ports were automatically shared)? I just want to make sure we have the right repro steps.

Also, when you say that your code was getting screwed up, do you mean that edits were being applied that neither participant was actually making?

@lifeiscontent
Copy link
Author

@lostintangent it was manual I didn't realize that you could do it automatically.

@lostintangent
Copy link
Member

Yep, we automatically discover servers (based on a list of well known ports) that are started from the integrated terminal. So if you run “npm start” from the VS Code terminal, we’d automatically share the port of the server it starts up.

That said, I’d love to understand more about the issue you noticed. I just tried reproing this and didn’t notice any issues with the cursor or code getting out of sync. Out of curiosity: do you recall if you renamed a file before the issues in step #4 occurred?

@lifeiscontent
Copy link
Author

@lostintangent I'll follow back up with a video once I start pairing again.

@lifeiscontent
Copy link
Author

@lostintangent I figured it out, it has to due with bad internet connections, when there is heavy latency VSCode I'm guessing is trying to send actions and when one of the participants is typing while VSCode tries to catch up, it gets out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@lostintangent @lifeiscontent and others