Implement 'path' property for Xcode #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazaval
requested review from
brownmike,
americanhanko,
ehanlon and
hushlorentz
v-anshie
approved these changes
Aug 31, 2018
This reverts commit 4851ae1.
ehanlon
approved these changes
Sep 10, 2018
jazaval
added a commit
that referenced
this pull request
Sep 11, 2018
* bump version * update Xcode documentation * Implement 'path' property for Xcode (#136) * first pass at supporting path property * clarify path_hash to more descriptive version_path_map * refactor path method to give valid output before xcode is done * add chefspec for Xcode resource * fix ShellOutNotStubbed error in SWU recipe spec * unify smoke tests for beta and non-beta xcodes * refactor CLT install, move guard into CLT class and update spec to pass * update spec tests to separate concerns with xcversion output and authentication * update classes and resources to pass tests * fix inclusions * include entire MacOS module * specify permissions for CLT sentinel file * remove laziness of commandlinetools detection, use FileUtils to manage * update the spec to have FileUtils handle sentinel * exclude non-beta compatible platforms * restore xcode beta smoke tests * Revert "exclude non-beta compatible platforms" This reverts commit 4851ae1. * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
pathproperty for Xcode, which will move the requested Xcode bundle to the specified path, and set the active developer directory to that location as well.If the requested version of Xcode is already present, it will move that version of Xcode to the requested path, overwriting if necessary.
The logic for this is tested at the resource, rather than library level, which requires
chefspec >= 7.3.0. Because of this, this PR also fixes a new ShellOutNotStubbed failure with thedisable_software_updatespec.Resolves #116