Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing for macos_user #48

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Improve testing for macos_user #48

merged 2 commits into from
Feb 20, 2018

Conversation

americanhanko
Copy link
Collaborator

This PR

  • Adds a cookbook group to the Berksfile so that smoke tests can be run in the root cookbook directoy
  • Adds better test coverage for the admin property in the macos_user resource
  • Adds new_resource. to properties that are missing it, which eliminates deprecation warnings

@americanhanko
Copy link
Collaborator Author

americanhanko commented Feb 16, 2018 •
edited
Loading

These builds are going to fail until we change the build definition to remove cd'ing into the test cookbook directory.

@americanhanko americanhanko changed the base branch from master to release/1.6 February 16, 2018 21:27
@jazaval jazaval self-requested a review February 16, 2018 21:34
@americanhanko americanhanko merged commit 59e41be into release/1.6 Feb 20, 2018
@americanhanko americanhanko deleted the feature/refine-macos-user branch February 20, 2018 07:46
americanhanko added a commit that referenced this pull request Feb 20, 2018
@americanhanko
Release/1.6 (#49)
40180c1 
* first attempt to solve defaults/plist resource whitespacing

* create the plist if it is missing

* better handling of new plists and novel entries

* Improve testing for macos_user (#48)

* better "admin" test coverage for macos_user

* all default suite tests passing

* fix kitchen yaml to enforce idempotency

* address comments in plist whitespace pull request

* fix syntax error with shellescape

* fix heredoc/cookstyle issue

* adjust whitespace for heredoc

* bump to release version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brownmike brownmike brownmike approved these changes

@jazaval jazaval jazaval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@americanhanko @brownmike @jazaval