Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different URL for workitems. #78

Merged
merged 3 commits into from Mar 31, 2018
Merged

Conversation

davisjr
Copy link
Member

@davisjr davisjr commented Jul 14, 2017

The sample config has a bug URL of the format _workitems#_a=edit&id=[_ID] and it works fine for the most parts. However, if the user is not already logged in, the bit after the # is lost after the login flow and the user ends up in the queries tab instead of the specific bug.

The URL _workitems?_a=edit&id=[_ID] works fine on VSTS but is not recognized in TFS 2013; _workitems/edit/[_ID] works in both.

With the previous format - _workitems#_a=edit&id=[_ID] - the fragment part is getting stripped if the user is redirected to the login flow. Using one of the alternate formats - _workitems?_a=edit&id=[_ID] or _workitems/edit/[_ID] - does not cause this.
@@ -22,8 +22,8 @@

<div class="subtitle">[TFSProject] &middot; [TFSWorkItemTemplate]</div>

<h1><a href="[TFSCollectionUri]/[TFSProject]/_workitems#_a=edit&amp;id=[_ID]">[_ID]</a></h1>
<h2><a href="[TFSCollectionUri]/[TFSProject]/_workitems#_a=edit&amp;id=[_ID]">[_TITLE]</a></h2>
<h1><a href="[TFSCollectionUri]/[TFSProject]/_workitems?_a=edit&amp;id=[_ID]">[_ID]</a></h1>
Copy link
Member Author

@davisjr davisjr Jul 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work in some versions of TFS (failed in TFS 2013). Needs more testing.

Copy link
Member Author

@davisjr davisjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work in some versions of TFS. Needs more testing.

@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
@davisjr davisjr force-pushed the master branch 2 times, most recently from 91cf798 to 0f5ee68 Compare January 30, 2018 14:13
@davisjr davisjr merged commit 4ef433f into microsoft:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants