Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local file config in isort & Add missing copyright info #547

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

lihuoran
Copy link
Contributor

Description

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@lihuoran lihuoran requested a review from Jinyu-W June 14, 2022 05:37
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #547 (1317df5) into master (7e3c1d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          85       85           
  Lines        5455     5455           
=======================================
  Hits         4304     4304           
  Misses       1151     1151           
Flag Coverage Δ
unittests 78.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
maro/data_lib/cim/port_buffer_tick_wrapper.py 100.00% <ø> (ø)
maro/event_buffer/event.py 100.00% <ø> (ø)
maro/event_buffer/event_linked_list.py 100.00% <ø> (ø)
maro/event_buffer/event_pool.py 100.00% <ø> (ø)
maro/simulator/utils/event_bind_binreader.py 32.00% <ø> (ø)
maro/utils/checkpoint.py 32.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3c1d5...1317df5. Read the comment docs.

Jinyu-W
Jinyu-W previously approved these changes Jun 14, 2022
@@ -4,4 +4,5 @@ line-length = 120
[tool.isort]
profile = "black"
line_length = 120
known_first_party = "maro"
known_first_party = ["maro"]
known_local_folder = ["examples", "scripts", "tests"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack of ending blank line?

@lihuoran lihuoran merged commit 8c0ad5a into master Jun 14, 2022
@lihuoran lihuoran deleted the fix_import_order branch June 14, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants