-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Input Template of RL Policy to Improve Module Flexisiblity #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_and_agent_state()
…ctor() of current TrainOps; add default False early_stop to update_actor() of current TrainOps
…ent sample() and eval()
21 tasks
lihuoran
reviewed
Mar 29, 2023
@@ -351,6 +360,7 @@ def _shape_check( | |||
self, | |||
states: torch.Tensor, | |||
actions: torch.Tensor = None, | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is **kwargs
used in _shape_check()
? Or you just want to keep it for future flexibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used yet. Only for future flexibility.
lihuoran
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RL Workflow:
RL Algorithms:
**kwargs
to support more problem setting (e.g., Graph based ones)**kwargs
to RL models'forward
funcs and_shape_check()
**kwargs
to RL policies'get_action
related funcs and_post_check()
**kwargs
tochoose_actions
ofAbsEnvSampler
; remain it None in currentsample()
andeval()
update_critic()
andupdate_actor()
of currentTrainOps
; add defaultFalse
early_stop
toupdate_actor()
of currentTrainOps
Linked issue(s)/Pull request(s)
Type of Change
Related Component
Has Been Tested
Needs Follow Up Actions
Checklist