Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test #590

Merged
merged 9 commits into from May 23, 2023

Conversation

lihuoran
Copy link
Contributor

@lihuoran lihuoran commented May 6, 2023

Description

  • Refine the RL exploration strategy, prioritized sampling is supported now
  • Add DDQN example
  • Add DQN algorithm test, performance evaluation result appended to test part

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@lihuoran lihuoran requested a review from Jinyu-W May 6, 2023 01:21
@lihuoran lihuoran marked this pull request as ready for review May 12, 2023 03:40
maro/rl/exploration/strategies.py Outdated Show resolved Hide resolved
**kwargs: Any,
) -> np.ndarray:
return np.array(
[act if np.random.random() > self._eps else np.random.randint(self._num_actions) for act in action],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for batch operation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add input and output description for newly added class/functions

maro/rl/exploration/strategies.py Show resolved Hide resolved
tests/rl/tasks/dqn/__init__.py Outdated Show resolved Hide resolved
tests/rl/tasks/dqn/__init__.py Outdated Show resolved Hide resolved
tests/rl/tasks/dqn/__init__.py Show resolved Hide resolved
@Jinyu-W
Copy link
Collaborator

Jinyu-W commented May 18, 2023

Update the title and description of this PR

@Jinyu-W Jinyu-W force-pushed the huoran/ddqn_and_prio_memory branch from 2811239 to a09750e Compare May 22, 2023 06:36
@Jinyu-W Jinyu-W changed the title Huoran/ddqn and prio memory Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test May 23, 2023
@Jinyu-W Jinyu-W merged commit 607d3b6 into v0.3 May 23, 2023
7 of 13 checks passed
@Jinyu-W Jinyu-W deleted the huoran/ddqn_and_prio_memory branch May 23, 2023 07:52
Jinyu-W added a commit that referenced this pull request Oct 27, 2023
* Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test (#590)

* Runnable. Should setup a benchmark and test performance.

* Refine logic

* Test DQN on GYM passed

* Refine explore strategy

* Minor

* Minor

* Add Dueling DQN in CIM scenario

* Resolve PR comments

* Add one more explanation

* fix env_sampler eval info list issue

* update version to 0.3.2a4

---------

Co-authored-by: Huoran Li <huoranli@microsoft.com>
Co-authored-by: Jinyu Wang <Wang.Jinyu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants