-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teaching tip spec #5
Conversation
Fixing picture size.
Fixed typos and error in "using" pattern in deferral example.
Removing unused declaration in deferral example.
Fixed ordering of first two example images.
Added proper controls to the content example's example content.
Fixed hyperlink in Content example.
Fixing the way bleeding content is set in the BleedingContent example code.
```C# | ||
public void OnFirstSaveButtonClick(object sender, RoutedEventArgs args) | ||
{ | ||
TeachingTipExample.IsOpen=true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have an example with a Behavior as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By Behavior, are you refering to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Behavior is referring to the XAML Behaviors noted above, I am not confident that an example of it here would maintain the scope of focus otherwise shown throughout Teaching Tip's documentation (which focuses on the features of TeachingTip as opposed to the spectrum of conditions and means for opening one) as much as if an example of Teaching Tip was instead included in the examples and documentation for Behavior? I am open to understanding this issue better if you think other or if there is a lapse of understanding on my part.
For what its worth, we are planning on showing a least a couple of these in the XAML Sample Gallery, such as how to delay an opening, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-hawker, I know there's been a lot of activity on this repo, so I just wanted to ping you again and make sure my answers are responding to the Behavior you intended to surface?
Updated use of "impermanent" to "transient"
Fixed closing tag in pointer example code. Co-Authored-By: SavoySchuler <saschule@microsoft.com>
Updating Deferral example to be more general.
and section title sizes to be consitent with doc format.
Original comment outdated, change already committed.
Merging in TeachingTip Spec.