Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaching tip spec #5

Merged
merged 158 commits into from
Apr 12, 2019
Merged

Teaching tip spec #5

merged 158 commits into from
Apr 12, 2019

Conversation

SavoySchuler
Copy link
Member

Merging in TeachingTip Spec.

@SavoySchuler SavoySchuler requested review from chigy, ryandemopoulos and a team January 23, 2019 22:02
@SavoySchuler SavoySchuler self-assigned this Jan 23, 2019
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
Fixed typos and error in "using" pattern in deferral example.
@SavoySchuler SavoySchuler requested a review from a team as a code owner January 23, 2019 23:13
Removing unused declaration in deferral example.
Fixed ordering of first two example images.
Added proper controls to the content example's example content.
Fixed hyperlink in Content example.
Fixing the way bleeding content is set in the BleedingContent example code.
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
```C#
public void OnFirstSaveButtonClick(object sender, RoutedEventArgs args)
{
TeachingTipExample.IsOpen=true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have an example with a Behavior as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By Behavior, are you refering to this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Behavior is referring to the XAML Behaviors noted above, I am not confident that an example of it here would maintain the scope of focus otherwise shown throughout Teaching Tip's documentation (which focuses on the features of TeachingTip as opposed to the spectrum of conditions and means for opening one) as much as if an example of Teaching Tip was instead included in the examples and documentation for Behavior? I am open to understanding this issue better if you think other or if there is a lapse of understanding on my part.

For what its worth, we are planning on showing a least a couple of these in the XAML Sample Gallery, such as how to delay an opening, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker, I know there's been a lot of activity on this repo, so I just wanted to ping you again and make sure my answers are responding to the Behavior you intended to surface?

active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Outdated Show resolved Hide resolved
active/teachingtip/TeachingTipSpec.md Show resolved Hide resolved
SavoySchuler and others added 2 commits January 30, 2019 11:29
Updated use of "impermanent" to "transient"
Fixed closing tag in pointer example code.

Co-Authored-By: SavoySchuler <saschule@microsoft.com>
Updating Deferral example to be more general.
@SavoySchuler SavoySchuler dismissed MikeHillberg’s stale review March 25, 2019 21:20

Original comment outdated, change already committed.

@SavoySchuler SavoySchuler merged commit 1f19b87 into master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants