-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Easily target and customize the BorderThickness property on controls #1031
Comments
If ThemeResources are made for the default border thicknesses, individual resources for specific controls would make sense also. The TextField and Form controls, should have a 2px thick border when focused/active - As should the GridView Selected border. Other borders should be 1px. Relevant issues #898 #895 #835 I have made an issue to discuss Text and Form controls, and that involves use of borders to clearly show behaviours and touch targets. #899 There could also be some scope for looking at the Button design, as Fabric and FastDNA buttons offer Outlined button styles, and these along with SplitButton would need consideration with ThemeResources. Also more complex controls like the CalendarFlyout, which uses 2px spacing between items. |
@mdtauk the way we're approaching this is to ensure that the BorderThickness property on the UIElement itself responds to the correct/appropriate control part(s) when set implicitly or explicitly. Then, we'll probably introduce individual thickness resources for each control as needed moving forward (release to release). Staggering the work like that means a higher likelihood of it getting done, and our customers and partners have something to work with sooner - however, it may mean we don't have all the thickness resources for every individual control available right out of the gate. |
Makes total sense. Update the controls so border thickness will function properly, make resources for global values, resources for each control, then fix the templates to use them. The Calendar flyout example wouldn't strictly use a border thickness value in this scenario, but would use margins, widths, or padding to control the spacing between the Day buttons. I know this comes at the Template/Resources stage - but I thought I should mention it because there may be other controls which would need adjusting to the new global thickness resources being implemented. |
@kikisaints , have you created a doc for the new property? |
Proposal: Easily target and customize the BorderThickness property on controls
Summary
This issue is linked/delivering for #835
Support easy customization of the BorderThickness property on all controls that have a defined border of 2px in the system today.
Rationale
Scope
The text was updated successfully, but these errors were encountered: