Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Update strokes that are currently using 2px to 1px #835

Closed
sravya03 opened this issue Jun 10, 2019 · 17 comments · Fixed by #1172
Closed

Proposal: Update strokes that are currently using 2px to 1px #835

sravya03 opened this issue Jun 10, 2019 · 17 comments · Fixed by #1172
Assignees
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Milestone

Comments

@sravya03
Copy link

sravya03 commented Jun 10, 2019

Proposal: Control border stroke consistency

Summary

Across Windows products, applications are moving against using thicker 2px borders in favor of lighter 1px borders. This is to update default control visuals to use lighter borders to align with the majority of the visuals being drawn and implemented (except for GridView).

Rationale

  • Web and app ecosystems are a mix of styles
  • Styles are emerging to enforce purpose and function
  • Apps and shell turn of fstrokes, others lighten and deemphasize
  • New design follow this trend, thus our updates should also follow

Scope

Capability Priority
Developers are able to use WinUI2.2* package and without any work, get the new Windows visual style. Must
Developers have flexibility to style values of border thickness without retemplating. (This is to be tracked by #1031.) Should
Developers and end users experience control update that feel coherent with the same controls used by Fabric, Edge, and Xbox. Should

*Just using the next version #.

Design details and visuals

All form type style controls to get 1px border update.
Button
DropDownButton
SplitButton
add link to comp

TimePicker entry point
ColorPicker controls on form
Visual comp

ComboBox entry point
Editable ComboBox entry point (NOTE: Focus state's accent color border remains 2px)
DatePicker entry point
CalendarPicker entry point
Visual comp

CheckBox
RadioButton
ToggleSwitch
Visual comp

TextBox (NOTE: Focus state's accent color border remains 2px)
RichEditBox (NOTE: Focus state's accent color border remains 2px)
Visual comp

TreeView's checkbox
Visual comp

GridView's checkbox
add link to comp

Open Questions

  • Will this impact layout?
@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage Jun 10, 2019
@jevansaks jevansaks added the area-UIDesign UI Design, styling label Jun 10, 2019
@jevansaks
Copy link
Member

Will this proposal address the problem that Xbox has right now where their system apps disable the automatic scaling because they need finer control over the thickness of lines?

@jevansaks jevansaks added the feature proposal New feature proposal label Jun 10, 2019
@jevansaks jevansaks moved this from Needs triage to Backlog in Controls Triage Jun 10, 2019
@msft-github-bot msft-github-bot added this to Freezer in Feature tracking Jun 10, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jun 10, 2019

I have proposed this myself, and I believe Microsoft did discuss it, but was conflicted. @chigy

buttons
Checks and Radios
combo boxes
Flyouts

@chigy
Copy link
Member

chigy commented Jun 11, 2019

Will this proposal address the problem that Xbox has right now where their system apps disable the automatic scaling because they need finer control over the thickness of lines?

@jevansaks , I do not believe so. I believe they use 1px. So we'd have to draw 0.5px to have them draw 1px at 200% scale factor.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 11, 2019

Will this proposal address the problem that Xbox has right now where their system apps disable the automatic scaling because they need finer control over the thickness of lines?

@jevansaks , I do not believe so. I believe they use 1px. So we'd have to draw 0.5px to have them draw 1px at 200% scale factor.

Does Xbox still use those thin 1 epx borders for UI elements. I thought that had been superseded by the new Filled in panels with 2 epx spacing between elements.

080173

Of course there could be separate ThemeResources for when the DeviceFamily is Xbox.

@chigy chigy added this to To do in Visual update Jun 11, 2019
@chigy chigy moved this from To do to Proposal written in Visual update Jun 11, 2019
@chigy
Copy link
Member

chigy commented Jun 12, 2019

Added an open issue.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 12, 2019

I posted this in the NumberBox issue, but I think it is relevant here now this is an open issue and a proposal being considered.

If the borders for the Text Field controls, as well as the pickers and other controls which share a design pattern.

Comparing Similar Controls

I have also added the Date/Time/Calendar pickers

@chigy
Copy link
Member

chigy commented Jun 13, 2019

Will this proposal address the problem that Xbox has right now where their system apps disable the automatic scaling because they need finer control over the thickness of lines?

@jevansaks , I do not believe so. I believe they use 1px. So we'd have to draw 0.5px to have them draw 1px at 200% scale factor.

Does Xbox still use those thin 1 epx borders for UI elements. I thought that had been superseded by the new Filled in panels with 2 epx spacing between elements.

Removed image

Of course there could be separate ThemeResources for when the DeviceFamily is Xbox.

@mdtauk , you are right, the Xbox design no longer uses the 1px line. However the answer to @jevansaks 's question remains the same. What we are doing here does not address the scaling issue.

@chigy
Copy link
Member

chigy commented Jun 13, 2019

I posted this in the NumberBox issue, but I think it is relevant here now this is an open issue and a proposal being considered.

@mdtauk , not sure what you mean? Open issue is merely asking if we make the 2px line to 1px, does it make the control smaller and does it introduce layout issues. I did not mean to say we are redesigning all of the controls? Where did I make a mistake?

@chigy
Copy link
Member

chigy commented Jun 13, 2019

Status update: Reviewed with WinUI team and there was no immediate concern with the design's plan here to make the 2px lines to 1px other than the open issue around whether that impacts layout. Will be part of the consideration before a formal pitch is made to WinUI team.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 13, 2019

I posted this in the NumberBox issue, but I think it is relevant here now this is an open issue and a proposal being considered.

@mdtauk , not sure what you mean? Open issue is merely asking if we make the 2px line to 1px, does it make the control smaller and does it introduce layout issues. I did not mean to say we are redesigning all of the controls? Where did I make a mistake?

@chigy I think I may have mis-interpreted the intention behind this issue. I thought the issue was asking if the borders should change, and so i contributed to the discussion. I am still relatively new to using GitHub.

The reason I posted the image was to illustrate a conceptual approach to handling borders on control to provide a consistent visual language to indicate how a control would function.

As for the open question :- Most controls with a border are still measured from their outer dimensions. Overlays will now have a shadow, but that shadow is not part of the bounding box for the controls. The buttons within the bordered controls will need some adjustments in padding around the Icon to maintain the touch target sizing.

@LucasHaines
Copy link

LucasHaines commented Jun 13, 2019

We discussed as this change when scoping the Density work in 1809. One item that came up was the impact this may have on sight impaired users. I wish I had more concrete data on this, but we didn't pursue it during user research testing due to time and resources. Might be a good open question.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 13, 2019

We discussed as this change when scoping the Density work in 1809. One item that came up was the impact this may have on sight impaired users. I wish I had more concrete data on this, but we didn't pursue it during user research testing due to time and resources. Might be a good open question.

Sounds like a good consideration. The focus state border would still be 2 epx thickness - but how High Contrast themes would adapt the controls needs to be considered too.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 18, 2019

Will the Calendar Picker/View get a change in border thickness?
image

image

It will change the size of the control so will need some careful thought, considering the space between the 40 x 40 boxes would reduce.

image

image
This sizing assumes a 2 epx outer border - which could be reduced to 1 epx (2 epx felt more solid)

@chigy
Copy link
Member

chigy commented Jun 19, 2019

Update:
Reviewed the controls once again with the design team and decided to break out the GridView becoming 4px as they are not the same type of issue. I've opened issue #898.

@chigy
Copy link
Member

chigy commented Jun 19, 2019

Will the Calendar Picker/View get a change in border thickness?

@mdtauk ,
Thanks for asking. No, it will not.

The problem we are trying to solve with this border thickness update is to make the UI that is always visible lighter weight as we received it is a bit too accentuated unnecessarily. Calendar view's borders are designed so that it works with the hover state that gets user's attention (so we are not making it 1px as it could make it less visible). In other words, we do not have a problem with the CalendarView today so we are not going to go change it unless we identify an issue.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 19, 2019

@chigy Thank you for the response

@chigy chigy moved this from Proposal written to WinUI 2.3 in Visual update Jun 25, 2019
@chigy chigy moved this from WinUI 2.3 to Proposal written in Visual update Jun 25, 2019
@kikisaints kikisaints moved this from Freezer to Back Burner in Feature tracking Jul 15, 2019
@msft-github-bot
Copy link
Collaborator

🎉This issue was addressed in #1172, which has now been successfully released as Microsoft.UI.Xaml v2.2.190822001-prerelease.:tada:

Handy links:

@jevansaks jevansaks moved this from Back Burner to Code Complete, needs Docs/Samples in Feature tracking Sep 10, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
Feature tracking
Code Complete, needs Docs/Samples
Development

Successfully merging a pull request may close this issue.

6 participants