ContentDialog Text Color Contrast

[carlos-zamora]

Describe the bug
The color contrast of hyperlinks and text in a ContentDialog does not meet the color contrast ratio of 4.5:1 for accessibility.

microsoft/terminal#5395 is dependent on a fix for this issue.

Steps to reproduce the bug
This can be seen in Windows Terminal's TerminalPage.xaml , but this just uses the built-in theme dictionaries.

Steps to reproduce the behavior:

1. Open your app of choice that uses a ContentDialog using HyperlinkButtons
2. Open Accessibility Insights (download link here) to check the color contrast ratio
3. Verify whether the color contrast ratio for the SplitButton control meets the 4.5:1 contrast ratio

Expected behavior
In Windows Terminal, the links present in the "About" pop up window and the text to the back ground color in the "OK" button should meet the color contrast ratio 4.5:1

Screenshots

Version Info

NuGet package version:

Windows 10 version	Saw the problem?
Insider Build (xxxxx)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)

Device form factor	Saw the problem?
Desktop
Mobile
Xbox
Surface Hub
IoT

[ranjeshj]

@carlos-zamora Is the blue color, the default blue shell accent color ?

[carlos-zamora]

@carlos-zamora Is the blue color, the default blue shell accent color ?

Yes. This one was another one submitted by the accessibility testers. Personally, I feel that using the accent color is correct, but I get how that could create a situation like this where the color contrast is not acceptable.

CC'ing @DHowett-MSFT to keep him in the loop.

[mdtauk]

When choosing an Accent Color, it does warn where there could be visibility problems - so if the user has chosen such a colour - then we can presume they take that risk.

The Windows team should have chosen an accent colour that meets contrast ratio recommendations right?

[ranjeshj]

@chigy can you route this bug ?

[chigy]

We are aware of this issue and will be sure to share this as additional information to the team that owns addressing this issue.

[YuliKl]

This issue is now fixed in the OS (by internal bug). Corrected accent color will be the default in the next version of Windows.

[mdtauk]

This issue is now fixed in the OS (by internal bug). Corrected accent color will be the default in the next version of Windows.

So this is the end of

00 78 D4

Looking at the design tokens, it looks like the way the Accent colour is applied to Light and Dark themes will be changing. Any chance you could share some information about this new formula for picking colours?

[StephenLPeters]

@YuliKl ?