Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Windows Terminal_About_Color Contrast: Links present in the "About" pop up window and the text to the back ground color in the "ok" button are not meeting the color contrast ratio 4.5:1 #5395

Closed
SpandanaPaladi opened this issue Apr 17, 2020 · 3 comments
Labels
Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@SpandanaPaladi
Copy link

SpandanaPaladi commented Apr 17, 2020

#A11y_WindowsTerminal; #WindowsTerminal; #A11yMAS; #A11yTCS; #DesktopApp; #Win10; #C+E-H; #ColorContrast; #A11ySev2; #NonBenchMark; #MAS1.4.3

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  2. Open ""Windows terminal (Preview)"" application
  3. Open the "Accessibility insights" tool to check color contrast ratio
  4. Tab to "Dropdown" control and press enter or use "Ctrl + Shift + Space"
  5. Tab till "About" and press enter
  6. Verify whether the links and the text to the back ground color in the "OK" button are meeting the color contrast ratio 4.5:1 or not

Actual Result:
The links present in the "About" pop up window and the text to the back ground color in the "OK" button are not meeting the color contrast ratio 4.5:1​

Expected Result:​
The links present in the "About" pop up window and the text to the back ground color in the "OK" button should meet the color contrast ratio 4.5:1

User Impact:​
Low vision users will face difficulty in viewing the content if the Color Contrast ratio fails to meet 4.5:1 ratio for links and text to the back ground color in the "OK" button

MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}

Bug_links in about popup not meeting color contrast ratio
Bug_text to the back ground color not meeting color contrast ratio

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Area-User Interface Issues pertaining to the user interface of the Console or Terminal labels Apr 17, 2020
@mdtauk
Copy link

mdtauk commented Apr 17, 2020

Isn't this down to the choice of Accent colour in the system?

@carlos-zamora
Copy link
Member

We just use the built-in ContentDialog from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo:
microsoft/microsoft-ui-xaml#2354

@Amulya-95
Copy link

Regressed the bug in latest environment. The issue is resolved, controls have color contrast ratio equal to 4.5:1. Hence closing this bug.
Please find the attachments for reference.

Attachments:
Fixed Bug 5395_Color contrast ratio passes for links

Fixed Bug 5395_Note section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants