-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teaching Tip doesn't move with the target #3050
Comments
It was a conscious decision to not have the teaching tip move with a target, primarily because we didn't have a good story for what to do with the teaching tip when the target was scrolled out of the view port. In that case it was causing the tip to look as if it were pointing at a different object. Our designers also found that a moving teaching tip was very distracting and thus the guidance is to not have tips which target components which you expect to move, or when they do to close the tip. Your idea of exposing a method which the consumer could use to reposition the tip is interesting. @SavoySchuler do you have thoughts on this? |
Thank you for your answer. For the method to reposition the tip, I saw that there is a RepositionPopup that is used when the window gets resized, and if that method is safe to use and exposed, that would be a good solution, and won't cause any issue with scrolling (or at least, it will be the consumer's responsibility) |
@KodWhat Could I trouble you to open a Feature Request issue? I think the feature request and the details in this issue are different enough that we shouldn't repurpose this. |
Given that there is #3062, is there any benefit in keeping this issue open or can we close it? |
I think that the two are slightly different. But I think that we could potentially close this as 'By Design'. @ranjeshj are you okay with that? |
Looks like both are talking about similar issues. Lets dup this and add more details to #3062 if necessary. Thanks! |
Describe the bug
When the control targeted with a Teaching Tip moves or changes, the Teaching Tip does not follow.
To note: A window resize will replace the Teaching Tip in the right place.
This might be related to #1609, where the Teaching Tip was repositioned on window resize but not on control move.
Steps to reproduce the bug
Here are three ways to reproduce :
Have a Teaching Tip attached to a button and shown. Change the width of the button. The teaching tip will not move, overlapping with the button.
Have another control show/hide while the teaching tip is opened as such that it moves the targeted control. The teaching tip will not move.
Have a teaching tip opened at application start. Have ExtendViewIntoTitleBar set to true on the view. The teaching tip will not adapt and overlap the targeted control.
Expected behavior
Either the Teaching Tip should reposition itself when its targets gets transformed (position, size, ...) or the RepositionPopup method should be made public to allow for manual refresh.
Screenshots
On this screenshot, the picture sidebar get shown after the teaching tip was opened, and ExtendViewIntoTitleBar is set to true.
Teaching Tip is attached to the Settings AppBarButton
Version Info
NuGet package version: Microsoft.UI.Xaml 2.4.2
The text was updated successfully, but these errors were encountered: