Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaching Tip doesn't move with the target #3050

Closed
KodWhat opened this issue Aug 5, 2020 · 6 comments
Closed

Teaching Tip doesn't move with the target #3050

KodWhat opened this issue Aug 5, 2020 · 6 comments
Labels
area-TeachingTip duplicate This issue or pull request already exists team-Controls Issue for the Controls team

Comments

@KodWhat
Copy link

KodWhat commented Aug 5, 2020

Describe the bug
When the control targeted with a Teaching Tip moves or changes, the Teaching Tip does not follow.

To note: A window resize will replace the Teaching Tip in the right place.

This might be related to #1609, where the Teaching Tip was repositioned on window resize but not on control move.

Steps to reproduce the bug
Here are three ways to reproduce :

  1. Have a Teaching Tip attached to a button and shown. Change the width of the button. The teaching tip will not move, overlapping with the button.

  2. Have another control show/hide while the teaching tip is opened as such that it moves the targeted control. The teaching tip will not move.

  3. Have a teaching tip opened at application start. Have ExtendViewIntoTitleBar set to true on the view. The teaching tip will not adapt and overlap the targeted control.

Expected behavior
Either the Teaching Tip should reposition itself when its targets gets transformed (position, size, ...) or the RepositionPopup method should be made public to allow for manual refresh.

Screenshots
Screenshot 2020-08-05 203806
On this screenshot, the picture sidebar get shown after the teaching tip was opened, and ExtendViewIntoTitleBar is set to true.
Teaching Tip is attached to the Settings AppBarButton

Version Info

NuGet package version: Microsoft.UI.Xaml 2.4.2

Windows 10 version Saw the problem?
Insider Build (20180) Yes
Device form factor Saw the problem?
Desktop Yes
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 5, 2020
@StephenLPeters
Copy link
Contributor

It was a conscious decision to not have the teaching tip move with a target, primarily because we didn't have a good story for what to do with the teaching tip when the target was scrolled out of the view port. In that case it was causing the tip to look as if it were pointing at a different object. Our designers also found that a moving teaching tip was very distracting and thus the guidance is to not have tips which target components which you expect to move, or when they do to close the tip.

Your idea of exposing a method which the consumer could use to reposition the tip is interesting. @SavoySchuler do you have thoughts on this?

@StephenLPeters StephenLPeters added area-TeachingTip team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Aug 5, 2020
@KodWhat
Copy link
Author

KodWhat commented Aug 5, 2020

Thank you for your answer.
To add more details about my use case :
I develop a weather app where the side picture is shown when there is a forecast available (Connected to internet and City selected).
When these conditions are not met or if the window is too small, that picture is hidden.
I use the Teaching Tip as a way to indicate what's new in an update (at least for now), so I show it as soon as the app is launched and before a forecast can be fetched (as it does not depend of the success of the forecast retrieval), causing the layout to reorganize when the forecast is shown.

For the method to reposition the tip, I saw that there is a RepositionPopup that is used when the window gets resized, and if that method is safe to use and exposed, that would be a good solution, and won't cause any issue with scrolling (or at least, it will be the consumer's responsibility)

@StephenLPeters
Copy link
Contributor

@KodWhat Could I trouble you to open a Feature Request issue? I think the feature request and the details in this issue are different enough that we shouldn't repurpose this.

@marcelwgn
Copy link
Contributor

Given that there is #3062, is there any benefit in keeping this issue open or can we close it?

@StephenLPeters
Copy link
Contributor

I think that the two are slightly different. But I think that we could potentially close this as 'By Design'. @ranjeshj are you okay with that?

@ranjeshj
Copy link
Contributor

Looks like both are talking about similar issues. Lets dup this and add more details to #3062 if necessary. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TeachingTip duplicate This issue or pull request already exists team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants