Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButtons Style Improvements [Issue Collection] #3759

Open
2 tasks
michael-hawker opened this issue Dec 4, 2020 · 4 comments
Open
2 tasks

RadioButtons Style Improvements [Issue Collection] #3759

michael-hawker opened this issue Dec 4, 2020 · 4 comments
Labels
area-RadioButtons feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@michael-hawker
Copy link
Collaborator

michael-hawker commented Dec 4, 2020

Describe the bug
I was trying to see if the RadioButtons control could be re-styled to support the Segmented Control scenario (#2310) as asked by @sonnemaf here on Twitter: https://twitter.com/fonssonnemans/status/1334606237820985345

I was able to get close from a style perspective (haven't tried functionality in terms of SelectedItem):

image

But trying to re-style RadioButtons as painful due to the following set of issues:

Linked Issues

TO DO
Should test out how re-styling works with selection to see if further issues need to be collected here. I was able to just set SelectedIndex on the RadioButtons and it seemed to surprisingly set the ToggleButton state, so maybe there's not much to do here?

Have my test work in a gist here: https://gist.github.com/michael-hawker/06bda503efa14fbb2a84896643c21959

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 4, 2020
@StephenLPeters StephenLPeters added area-RadioButtons team-Controls Issue for the Controls team labels Dec 5, 2020
@StephenLPeters
Copy link
Contributor

This is awesome! retemplating is great when it works. hopefully we can resolve these styling issues.

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Dec 5, 2020
@sonnemaf
Copy link
Contributor

sonnemaf commented Dec 7, 2020

I want the RadioButtons to have animations, see my mock-up video https://twitter.com/fonssonnemans/status/1334816598599880705

image

@StephenLPeters
Copy link
Contributor

I think its probably difficult to get this style of animation with a simple retemplate of RadioButtons... You might be able to do it with a new VSM group and calling go to state yourself in the checked/unchecked handlers of retemplated toggle switches you put as children of the RadioButtons. Seems tricky but maybe possible.

@niels9001
Copy link
Contributor

We have recently published the new Segmented control and TokenView controls as part of the Windows Community Toolkit Labs. I think these controls are very much in line what is discussed here.

Segmented control

  • Supports single and multi selection.
  • Comes with 3 different styles (default, Pivot-like style and button style).

More info here: CommunityToolkit/Labs-Windows#392

224975096-73bdeaec-411e-418a-ac5e-42d67d896017

TokenView

  • Supports single and multi selection
  • Allows for wrapping TokenItems
  • Items can be removed as well

More info here: CommunityToolkit/Labs-Windows#427

233386908-009022d2-42a2-4021-b785-35ffe0facf32

@DmitriyKomin DmitriyKomin added the feature proposal New feature proposal label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-RadioButtons feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants