Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back Button Size to be reduced #57

Closed
BalaganEngg opened this issue Dec 10, 2018 · 4 comments
Closed

Back Button Size to be reduced #57

BalaganEngg opened this issue Dec 10, 2018 · 4 comments
Assignees
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team

Comments

@BalaganEngg
Copy link

wp_ss_20181210_0002
Back Button size is greater than Hamburger Menu button it not suitable for view

This is captured on mobile 640XL using Windows Template Studio

and I also studied something About Showing Alt + Left Tool tip when hover anywhere on the app.

To avoid that Windows Template Studio Created this Line of Code at Shell page

private void OnLoaded(object sender, RoutedEventArgs e)
{
// Keyboard accelerators are added here to avoid showing 'Alt + left' tooltip on the page.
// More info on tracking issue #8
KeyboardAccelerators.Add(_altLeftKeyboardAccelerator);
KeyboardAccelerators.Add(_backKeyboardAccelerator);
}

but this code Throw an error for Mobile Application.

Please Review this Also

@jevansaks jevansaks added the bug Something isn't working label Dec 10, 2018
@jevansaks
Copy link
Member

@sibille Are you aware of the second issue reported here where WTS generates unconditional code that doesn't run on Phone? If not, would you open an issue on your side?

@sibille
Copy link

sibille commented Dec 10, 2018

Thanks @jevansaks, I'll open an issue on WTS for the second part

@jevansaks jevansaks added the area-NavigationView NavView control label Dec 20, 2018
@jevansaks jevansaks assigned chrisglein and unassigned licanhua Dec 20, 2018
@jevansaks jevansaks added this to Approved in Controls Triage Feb 11, 2019
@jevansaks jevansaks added this to In progress in Controls Dev Feb 21, 2019
@jevansaks jevansaks moved this from Approved to Approved - Assigned in Controls Triage Feb 22, 2019
@chrisglein
Copy link
Member

The NavigationViewBackButton is set to 40x40 by its style. 24pt icon. Picked up from rs_generic.xaml.
The TogglePaneButton is set to 48x44 according to its RS2 style. 16pt icon.

Running the same app on desktop (not phone), we pick up RS5 styles and TogglePaneButton has dropped to 40x40 according to the new RS5 standard density. The NavigationViewBackButon remains at 40x40. So they match in footprint. They also match with 16pt icons.

So there are two issues: The control footprints are different. Also the back button icon size is larger.

Switching to the 2.1 prelease build the footprint is fixed (due to downlevel density); both are 40x40. But the 24pt back button icon remains. Again, this appears to be a phone-specific difference. On desktop the icon is 16pt.

@jevansaks
Copy link
Member

Sadly, phone is going out of support at the end of the year so unless we have a repro on a supported platform (desktop, xbox, etc) then we can't justify spending time on this.

Controls Triage automation moved this from Approved - Assigned to Closed Mar 21, 2019
Controls Dev automation moved this from In progress to Done Mar 21, 2019
@msft-github-bot msft-github-bot removed this from Closed in Controls Triage Mar 21, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team
Projects
No open projects
Controls Dev
  
Done
Development

No branches or pull requests

5 participants