Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavView and Alt + Left KeyBoardAccelerators #8

Closed
sibille opened this issue Oct 17, 2018 · 12 comments
Closed

NavView and Alt + Left KeyBoardAccelerators #8

sibille opened this issue Oct 17, 2018 · 12 comments
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team

Comments

@sibille
Copy link

sibille commented Oct 17, 2018

We're having an issue with WinUI NavView and the Alt + Left KeyboardAccelerator.
Initially we added the KeyboardAccelerator in the page constructor (following guidance from
https://docs.microsoft.com/en-us/windows/uwp/design/basics/navigation-history-and-backwards-navigation), but doing this the "Alt + Left" Tooltip is showing all over the app.

We saw in your samples (https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/navigationview#code-example) that you are adding the accelerator in the NavView Loaded event handler. Moving the code here results in not showing the tooltip.

Is NavView_Loaded or Page_Loaded the correct place to add KeyboardAccelerators?

Working on this we also noticed that the NavView BackButton does not have a tooltip. Should this tooltip de provided out of the box (like the Hamburger Button does) or are we missing something?

I'll attach a generated app so you can see what we are generating.
NavViewTooltip.zip

Tracking issue on our side is microsoft/TemplateStudio#2650

@jevansaks
Copy link
Member

For the first issue (keyboard accelerators), we'll file a bug on the appropriate team to investigate and report back.

For the second issue (missing back button tooltip), we were unable to fix it for the last release but it's already been addressed and will be in our next major update.

@jesbis jesbis added this to Needs triage in Controls Triage Oct 24, 2018
@jevansaks
Copy link
Member

Filed on engineering team (Internal tracking link)

Controls Triage automation moved this from Needs triage to Closed Nov 6, 2018
@jevansaks
Copy link
Member

Leaving as open until we have closure on the internal side of things.

@jevansaks jevansaks reopened this Nov 6, 2018
Controls Triage automation moved this from Closed to Needs triage Nov 6, 2018
@jevansaks jevansaks added the area-NavigationView NavView control label Dec 20, 2018
@jevansaks jevansaks removed this from Needs triage in Controls Triage Jan 22, 2019
@jevansaks jevansaks added this to Approved in Controls Triage Feb 11, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@marcelwgn
Copy link
Contributor

@ranjeshj @jevansaks Can we close this issue now? The corresponding issue over at WindowsTemplateStudio has been closed and it sounds like the fix for this was already added back then.

@jevansaks
Copy link
Member

No objections from me.

@mvegaca
Copy link

mvegaca commented Feb 17, 2021

Hi

Adding keyboardAccelerators to WinUI 3 Preview 4 Templates in WindowsTemplateStudio I've verified that this tooltip issue still happens.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 17, 2021
@StephenLPeters
Copy link
Contributor

@jevansaks or @chingucoding do you remember this one?

@ghost ghost removed the needs-triage Issue needs to be triaged by the area owners label Feb 19, 2021
@marcelwgn
Copy link
Contributor

Could it be that there is a regression in WindowsTemplateStudio for the preview4 version? Or is the Preview 4 NavView different from the WinUI 2 one?

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 19, 2021
@StephenLPeters
Copy link
Contributor

@sibille FYI

@ghost ghost removed the needs-triage Issue needs to be triaged by the area owners label Feb 20, 2021
@jevansaks
Copy link
Member

@jevansaks Jevan Saks FTE or @chingucoding do you remember this one?

Looks like the internal bug I linked earlier is still active.

@sibille
Copy link
Author

sibille commented Feb 23, 2021

I just double checked and can confirm that this issue is still happening, both on WinUI 2.5 and WinUI3 Preview 4.
We currently add the keyBoardAccelerators in the OnLoaded Event, but if I move them back to the ViewModel initialization I can see the Alt+ Left Tooltip pop up again.

image
Repro app (using WinUI 2.5): App1.zip

Can we reopen this? Will also create a tracking issue on our side.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 23, 2021
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Feb 25, 2021
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team
Projects
No open projects
Development

No branches or pull requests

6 participants