-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavView and Alt + Left KeyBoardAccelerators #8
Comments
For the first issue (keyboard accelerators), we'll file a bug on the appropriate team to investigate and report back. For the second issue (missing back button tooltip), we were unable to fix it for the last release but it's already been addressed and will be in our next major update. |
Filed on engineering team (Internal tracking link) |
Leaving as open until we have closure on the internal side of things. |
@ranjeshj @jevansaks Can we close this issue now? The corresponding issue over at WindowsTemplateStudio has been closed and it sounds like the fix for this was already added back then. |
No objections from me. |
Hi Adding keyboardAccelerators to WinUI 3 Preview 4 Templates in WindowsTemplateStudio I've verified that this tooltip issue still happens. |
@jevansaks or @chingucoding do you remember this one? |
Could it be that there is a regression in WindowsTemplateStudio for the preview4 version? Or is the Preview 4 NavView different from the WinUI 2 one? |
@sibille FYI |
Looks like the internal bug I linked earlier is still active. |
I just double checked and can confirm that this issue is still happening, both on WinUI 2.5 and WinUI3 Preview 4.
Can we reopen this? Will also create a tracking issue on our side. |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
We're having an issue with WinUI NavView and the Alt + Left KeyboardAccelerator.
Initially we added the KeyboardAccelerator in the page constructor (following guidance from
https://docs.microsoft.com/en-us/windows/uwp/design/basics/navigation-history-and-backwards-navigation), but doing this the "Alt + Left" Tooltip is showing all over the app.
We saw in your samples (https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/navigationview#code-example) that you are adding the accelerator in the NavView Loaded event handler. Moving the code here results in not showing the tooltip.
Is NavView_Loaded or Page_Loaded the correct place to add KeyboardAccelerators?
Working on this we also noticed that the NavView BackButton does not have a tooltip. Should this tooltip de provided out of the box (like the Hamburger Button does) or are we missing something?
I'll attach a generated app so you can see what we are generating.
NavViewTooltip.zip
Tracking issue on our side is microsoft/TemplateStudio#2650
The text was updated successfully, but these errors were encountered: