Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rounded corners #659

Closed
30 of 32 tasks
chrisglein opened this issue May 6, 2019 · 11 comments
Closed
30 of 32 tasks

Feature: Rounded corners #659

chrisglein opened this issue May 6, 2019 · 11 comments
Assignees
Labels
area-Styling team-Controls Issue for the Controls team
Milestone

Comments

@chrisglein
Copy link
Member

chrisglein commented May 6, 2019

Tracking item for ensuring our control adequately set supports rounded corners (CornerRadius > 0).

  • Basic Input
    • Button
    • DropDownButton
      • and Flyout
    • SplitButton
      • and Flyout
    • Slider
      • thumb
      • track
      • filled track
    • Checkbox
    • ToggleButton
    • ToggleSplitButton
  • Collections
    • Multi-select
      • Multi-select list items
      • Multi-select TreeView
      • Multi-select GridView (larger checkbox rounding)
    • FlipView
  • Dialogs & Flyouts
    • Dialogs
    • Flyouts
  • Text
    • TextBox
    • PasswordBox
    • AutoSuggestBox
      • and Flyout (only bottom corners)
    • RichEditBox
  • Scrolling
    • Panning scrollbar
  • Status & Information
    • ProgressBar
    • Tooltips
    • TeachingTip
  • Menus & toolbars
    • CommandBarFlyout
    • MenuFlyout
    • MenuBar flyout
  • NavigationView
    • Selected item pill/fry
  • Pivot
    • Selected item underline
  • Pickers
    • ComboBox
      • box
      • flyout (only bottom corners, box bottom removed)
    • DatePicker
      • box
      • flyout
    • CalendarDatePicker
      • box
      • flyout
    • CalendarView
  • TimePicker
    • box
    • flyout
  • ColorPicker
    • main picker
    • preview
    • slider
    • input boxes
  • MediaPlayer
    • track
@chrisglein chrisglein self-assigned this May 6, 2019
@jevansaks jevansaks added this to the WinUI 2.2 milestone May 7, 2019
@lukeblevins
Copy link
Contributor

Another obvious example of no CornerRadius support I noticed was the AutoSuggestBox.

@chigy
Copy link
Member

chigy commented May 31, 2019

@chrisglein , I don't think CalendarView needs any change?

@chigy
Copy link
Member

chigy commented May 31, 2019

@chrisglein , here are some items that were missing from the list.

  • Pivot - selection bar
  • Media player - Tooltip (it should get by the work on Tooltip but being precise)
  • Time Picker - Is this included in Date Picker?
  • Toggle Button - Is this part of button?
  • ToggleSplitButton - Is this part of split button?
  • Web view - I don't know if slider there needs separate work

@chrisglein
Copy link
Member Author

Pivot - selection bar

Good catch. Added to the list.

Media player - Tooltip (it should get by the work on Tooltip but being precise)

This one doesn't use a different tooltip type, does it? As long as it's a vanilla ToolTip it should be covered.

Time Picker - Is this included in Date Picker?

Neglected to have that on my list (even though I had to do work to fix it). No, this isn't covered by DatePicker - they're separate. I just missed this one when referencing the figma page. Added now.

Toggle Button - Is this part of button?

Worth calling out separately. I'll add it.

ToggleSplitButton - Is this part of split button?

Probably? I'll add it to be explicit.

Web view - I don't know if slider there needs separate work

Which slider? Do you mean scrollbars?

@chrisglein
Copy link
Member Author

@chrisglein , I don't think CalendarView needs any change?

CalendarView seemed to work as is. I don't think we need to change it based on what I'm seeing.

@chigy
Copy link
Member

chigy commented Jun 3, 2019

@chrisglein ,

  • To make sure that Media player gets the outcome we want (even if it is free), would you at least test it to make sure?
  • Sorry, yes, Webview question was about scrollbars.

@saniyamazmanova
Copy link

Is it possible to get corner radius values for the items on the list?

@mdtauk
Copy link
Contributor

mdtauk commented Jul 19, 2019

@chrisglein , I don't think CalendarView needs any change?

CalendarView seemed to work as is. I don't think we need to change it based on what I'm seeing.

When placed as a control it should use the 2px corner radius right? 4px when used as a flyout?

@kaiguo
Copy link
Contributor

kaiguo commented Jul 19, 2019

Is it possible to get corner radius values for the items on the list?

The default values are 2 for controls and 4 for overlays. https://github.com/microsoft/microsoft-ui-xaml-specs/pull/32/files#diff-7e5bdf641a5e75aa9cef33ea78c49a71

@kaiguo
Copy link
Contributor

kaiguo commented Jul 19, 2019

@chrisglein

        Chris Glein
        FTE , I don't think CalendarView needs any change?

CalendarView seemed to work as is. I don't think we need to change it based on what I'm seeing.

When placed as a control it should use the 2px corner radius right? 4px when used as a flyout?

Correct, CalendarView has 2px CornerRadius, and it gets 4px radius when used inside the CalendarDatePicker Flyout.

@kaiguo
Copy link
Contributor

kaiguo commented Aug 21, 2019

There's a separate issue #1096 tracking ListviewItem and GridViewItem updates after WinUI 3. Closing this one.

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Styling team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

7 participants