Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Minimize/maximize/close broken by 1.0.1 runtime update with customized title bar #6859

Closed
1 of 2 tasks
fredemmott opened this issue Mar 20, 2022 · 4 comments
Closed
1 of 2 tasks
Labels
area-TitleBar Issues related to custom window title bars. product-winui3 WinUI 3 issues team-Reach Issue for the Reach team

Comments

@fredemmott
Copy link

fredemmott commented Mar 20, 2022

Describe the bug

I am using Microsoft::UI::Xaml::Window with ExtendsContentIntoTitleBar

This works fine but is a bit awkward with the 1.0.0 libraries.

With 1.0.1 runtime - no rebuild - they visually act as expected (hover/click color changes), but they don't minimize/maximize/close the window.

Steps to reproduce the bug

  1. Get a clean windows install with no Windows App runtime
  2. manually install windows app runtime 1.0.0
  3. install MSIX from https://github.com/fredemmott/OpenKneeboard/releases/tag/v0.2.1
  4. test minimize/maximize/close in that app (openkneeboard). They work fine.
  5. close openkneeboard
  6. install windows app runtime 1.0.1 update
  7. launch open kneeboard
  8. minimize/maximize/close still have visual effects on hover/click (color changes) but no longer minimize/maximize/close the app

Expected behavior

Minimize/close/maximize buttons should minimize/maximize/close the window with 1.0.1 runtime as they did in 1.0.0.

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.0

Windows app type

  • UWP
  • Win32

Device form factor

Desktop

Windows version

Windows 10 (21H2): Build 19044

Additional context

No response

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 20, 2022
fredemmott added a commit to OpenKneeboard/OpenKneeboard that referenced this issue Mar 20, 2022
Broken by windows app runtime 1.0.1 update: microsoft/microsoft-ui-xaml#6859
@ojhad ojhad added team-Reach Issue for the Reach team product-winui3 WinUI 3 issues area-TitleBar Issues related to custom window title bars. labels Mar 21, 2022
@ojhad
Copy link
Contributor

ojhad commented Mar 21, 2022

@bpulliam @pratikone please take a look

@pratikone
Copy link
Contributor

see if it is same issue as #6895 . Remove the right margin from titlebar element. it shifts the whole custom titlebar to left enough that caption buttons stop working. working to get the docs updated

@pratikone pratikone added the duplicate This issue or pull request already exists label Mar 31, 2022
@fredemmott
Copy link
Author

fredemmott commented Mar 31, 2022

I tried that; it fixed the buttons, but it also shifted the overall layout a bunch; after around an hour, I hadn't found a way to get both the buttons to work, and to have the content in the correct position.

Regardless, I don't think having to change the code should be the expectation/fix for compatibility with an automatically-installed .z update to a stable release

@pratikone
Copy link
Contributor

yeah, we were fixing a few things. with new updates, it will ignore any margin (except for left margin). do try that out. I am closing this bug, if you continue to face any issue, feel free to open this up.

@ghost ghost removed the needs-triage Issue needs to be triaged by the area owners label Jul 12, 2022
@krschau krschau removed the duplicate This issue or pull request already exists label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TitleBar Issues related to custom window title bars. product-winui3 WinUI 3 issues team-Reach Issue for the Reach team
Projects
None yet
Development

No branches or pull requests

4 participants