Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SplitButton #986

Closed
sravya03 opened this issue Jul 3, 2019 · 10 comments · Fixed by #1173
Closed

Update SplitButton #986

sravya03 opened this issue Jul 3, 2019 · 10 comments · Fixed by #1173
Assignees
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Milestone

Comments

@sravya03
Copy link

sravya03 commented Jul 3, 2019

Summary

Update the SplitButton to a new visual design, separating the button and drop down.

Rationale

  1. Visually separate the two hit targets since they currently blend together and unintentionally look like one hit target
  2. Is not visually distinct from the dropdown control (i.e. a split button and a drop down can appear to look like the same control)

image

@sravya03 sravya03 added the feature proposal New feature proposal label Jul 3, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jul 3, 2019

I think you mean the Split Button, as the Drop Down Button is a single touch target...

Buttons

@YuliKl YuliKl added the area-UIDesign UI Design, styling label Jul 8, 2019
@chigy chigy changed the title Update DropDownButton Update SplitButton Jul 9, 2019
@chigy
Copy link
Member

chigy commented Jul 9, 2019

I think you mean the Split Button, as the Drop Down Button is a single touch target...

@mdtaulk , yup, SplitButton. Thanks for the correction. I've corrected the item.

@Poopooracoocoo
Copy link

Is this related to #899?

@chigy
Copy link
Member

chigy commented Jul 9, 2019

Is this related to #899?

@Poopooracoocoo , no it is not.

@mdtauk
Copy link
Contributor

mdtauk commented Jul 9, 2019

@chigy not directly, but it is about making the two separate touch targets within the SplitButton control more obvious visually - which is what the discussion in issue #899 is considering

@chigy
Copy link
Member

chigy commented Jul 10, 2019

@chigy not directly, but it is about making the two separate touch targets within the SplitButton control more obvious visually - which is what the discussion in issue #899 is considering

Similar but not exactly the same. #899 is about changing the system style of what we call buddy button that lives inside the TextBox OR proposing not to use buddy button and use multiple buttons. This request is literally making two buttons separated visually.

@chigy
Copy link
Member

chigy commented Jul 10, 2019

Status update:

Visual comp is added.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 2, 2019

I have updated my design following the proposed 4 button styles

image

@mdtauk
Copy link
Contributor

mdtauk commented Aug 13, 2019

Here is a more thorough design idea for the Split Button - including the toggled states.

Split Button - 14-08-2019

@msft-github-bot
Copy link
Collaborator

🎉This issue was addressed in #1173, which has now been successfully released as Microsoft.UI.Xaml v2.2.190830001.:tada:

Handy links:

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants