Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView: Adding boolean property NavigationView.IsTitleBarAutoPaddingEnabled #1015

Merged

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jul 8, 2019

Incremental work done for Issue #47.

We are adding a NavigationView.IsTitleBarAutoPaddingEnabled boolean property set to True by default.
When set to False, we skip adding the top padding that has the height of the title bar.

As part of these changes I also fixed the following:

  • In OnApplyTemplate, the section "// Register for changes in title bar layout" was misplaced as the m_topNavGrid field was not set yet.
  • NavigationView::UpdateTitleBarPadding, m_togglePaneTopPadding.Height / m_contentPaneTopPadding.Height were not reset to 0 when needsTopPadding is False.

Updated a couple of tests using the new property.

@RBrid RBrid added the area-NavigationView NavView control label Jul 8, 2019
@RBrid RBrid requested a review from a team July 8, 2019 22:34
@RBrid RBrid self-assigned this Jul 8, 2019
@RBrid RBrid merged commit 6541430 into master Jul 8, 2019
@jevansaks jevansaks deleted the user/rbrid/NavigationViewIsTitleBarAutoPaddingEnabled branch July 9, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants