Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SAL annotations and cleanup BUILD_WINDOWS #1102

Merged
merged 9 commits into from Jul 29, 2019
Merged

Remove SAL annotations and cleanup BUILD_WINDOWS #1102

merged 9 commits into from Jul 29, 2019

Conversation

ranjeshj
Copy link
Contributor

Removing SAL from a handful of files and updating to more modern code. Also removing BUILD_WINDOWS conditional code since we are not building in Windows anymore.

@ranjeshj ranjeshj requested review from jevansaks and a team July 25, 2019 20:30
jevansaks
jevansaks suggested changes Jul 25, 2019
View reviewed changes
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

jevansaks
jevansaks reviewed Jul 26, 2019
View reviewed changes
dev/inc/SharedHelpers.h Outdated Show resolved Hide resolved
@ranjeshj ranjeshj added the auto merge This PR will be merged once all checks pass label Jul 27, 2019
jevansaks
jevansaks approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

@msft-github-bot msft-github-bot merged commit 6a8ac7c into master Jul 29, 2019
@msft-github-bot msft-github-bot deleted the user/ranjeshj/removesal branch July 29, 2019 17:48
@jevansaks
Copy link
Member

Oops auto merge. I guess I should have checked for that before approving.

@ranjeshj ranjeshj mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llongley llongley llongley left review comments

@jevansaks jevansaks jevansaks approved these changes

Assignees
No one assigned
Labels
auto merge This PR will be merged once all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ranjeshj @jevansaks @llongley @msft-github-bot