Update CornerRadiusFilterConverter to work around a TemplateBinding bug #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeHillberg We added some new values to the CornerRadiusFilterKind enum in order to make this work. "TopLeftValue" and "BottomRightValue" will filter out the value and return the result in double type. |
jevansaks
reviewed
Aug 29, 2019
jevansaks
reviewed
Aug 29, 2019
jevansaks
reviewed
Aug 29, 2019
jevansaks
reviewed
Aug 30, 2019
| public void CornerRadiusTest() | ||
| { | ||
| var button = new Button(FindElement.ByName("GetCheckBoxRectangleCornerRadiusValue")); | ||
| button.Click(); |
There was a problem hiding this comment.
Recommend using Invoke() instead of Click() (which is mouse input) for better speed and reliability
jevansaks
approved these changes
Aug 30, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
msft-github-bot
deleted the
user/kaiguo/corner-radius-converter-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an issue that binding expression like below does not work in C++/CX apps.
RadiusX="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=CornerRadius.TopLeft}"Updated CornerRadiusFilterConverter so we can get a double typed CornerRadius value for a specific corner, then updated binding expressions to use converter instead. New expression using converter looks like this
RadiusX="{Binding CornerRadius, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource TopLeftCornerRadiusDoubleValueConverter}}"Also added a CornerRadius test page in TestAppCX to test out the changes.