Update use of weak_ref in SwipeControl to avoid potential race condition #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranjeshj
approved these changes
Nov 8, 2019
jevansaks
added
the
release note
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A speculative fix for: #890
The issue is that we are attempting to resolve a weak ref to a managed object (sub-class of SwipeControl) that has already been garbage collected.
I have never been able to reproduce the crash from #890, so I cannot confirm that this change resolves the issue. But this change removes a potential race condition in SwipeControl. Before checking a weak_ref for equality, we first take a strong ref to ensure that the object does not get destroyed between the time we check the weak ref and the time we use it.