Fix to layout cycle issue in Terminal #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
jevansaks
added
area-TabView
needs-cherrypicktorelease
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kaiguo
approved these changes
Dec 3, 2019
teaP
added a commit
that referenced
this pull request
Dec 3, 2019
jevansaks
pushed a commit
that referenced
this pull request
Dec 11, 2019
jevansaks
removed
the
needs-cherrypicktorelease
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides fix for Terminal bug:
microsoft/terminal#3303
microsoft/terminal#2277
Instead of relying on auto scrollbar visibility, which was causing the layout cycle, we are now calculating it ourselves based on the ItemsPresenter width vs. available width.