Make TabItems as content property of TabView #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
stmoy
reviewed
Jan 15, 2020
stmoy
approved these changes
Jan 15, 2020
| @@ -46,6 +46,7 @@ runtimeclass TabViewTabDragCompletedEventArgs | |||
|
|
|||
| [WUXC_VERSION_MUXONLY] | |||
| [webhosthidden] | |||
| [contentproperty("TabItems")] | |||
There was a problem hiding this comment.
it surprises me that this doesn't come with any generated files changes
There was a problem hiding this comment.
I believe the way this works is that this attribute gets tacked onto the winmd metadata and the parser can then get this information from the metadata. @danzil might be able to elaborate more.
StephenLPeters
added
area-TabView
team-Controls
michael-hawker
added a commit
to michael-hawker/windows-uwp
that referenced
this pull request
May 26, 2020
This was updated to not be needed: microsoft/microsoft-ui-xaml#1845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make TabItems as content property of TabView. It matches the documentation we already have and how ItemsControl currently behaves.
fixes #1844