Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AutoSuggestBox not respecting common TextBox properties #2252

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Fix AutoSuggestBox not respecting common TextBox properties #2252

merged 7 commits into from
Apr 29, 2020

Conversation

Felix-Dev
Copy link
Contributor

Description

This PR makes the AutoSuggestBox control consume the following properties now:

  • Foreground
  • Background
  • BorderBrush
  • BorderThickness

Motivation and Context

Fixes #2249.

How Has This Been Tested?

Tested visually.

Screenshots (if appropriate):

The following XAML gives the look below:

<AutoSuggestBox Header="AutoSuggestBox" MinWidth="200"
                Foreground="Blue"
                Background="#FF404040"
                BorderBrush="Orange"
                BorderThickness="2"/>

image

kmahone and others added 2 commits April 6, 2020 09:54
@kmahone
Switch ColorPicker to use tracker_ref (microsoft#2191)
209a153 
* Switch ColorPicker to use tracker_ref

* fix ProcessHelixFiles.ps1. Increase work item timeout

* CR feedback

Co-authored-by: Keith Mahoney <keith.mahoney@microsoft.com>

Follow up to: microsoft#2191 Switch ColorPicker to use tracker_ref  (microsoft#2225)

* update tracker ref use

* tab--
@Felix-Dev
AutoSuggestBox respects Foreground, Background, BorderBrush and Borde…
e99c161 
…rThickness now
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 8, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

StephenLPeters
StephenLPeters approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

@Felix-Dev as expected the visual tree verification tests failed. Can you please update the masters?

@Felix-Dev
Copy link
Contributor Author

@StephenLPeters should I wait until commit #2198 is merged into master, we ran the tests here again and I can use the new visual tree masters now containing #2198 changes too?

@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Apr 9, 2020
@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

There was a test failure in the previous run of the build. However the builds get cleaned up after a while, so it is no longer available.

I've kicked off another run of the build. Once that is available we will be able to investigate. Likely an xml master file needs to be updated.

@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

I've merged the latest from master and updated the xml masters. I've kicked off another run of the build which should pass the tests now.

@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

Missed a set of masters in the previous push. I think it should be good now.

@kmahone
Copy link
Member

kmahone commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 28, 2020

Hmmm. Another xml dump verification failure. I'll take a look.

@kmahone
Copy link
Member

kmahone commented Apr 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 473932e into microsoft:master Apr 29, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/autosuggestbox-styling branch April 29, 2020 09:15
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Apr 30, 2020
@Kinnara
Fix AutoSuggestBox not respecting common TextBox properties (microsof…
18e9917 
…t/microsoft-ui-xaml#2252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-AutoSuggestBox area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoSuggestBox should respect typical TextBox properties
5 participants
@Felix-Dev @StephenLPeters @kmahone @ranjeshj @msft-github-bot