Fix issue with ContentDialog not respecting BorderThickness property set #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
StephenLPeters
added
area-Dialogs
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
There was a test failure related to the VisualTree verification, I've updated the visual tree verification files now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting the BorderThickness property of a ContentDialog, it was not respected since we were not template binding to the BorderThickness of the ContentDialog.
Motivation and Context
Fixes #2525
How Has This Been Tested?
Tested manually:
Screenshots (if appropriate):