MUXTestInfra refactor #3212
Merged
MUXTestInfra refactor #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
kmahone
reviewed
Aug 28, 2020
kmahone
reviewed
Aug 28, 2020
kmahone
reviewed
Aug 28, 2020
kmahone
reviewed
Aug 28, 2020
kmahone
reviewed
Aug 28, 2020
kmahone
reviewed
Aug 28, 2020
|
Commenter does not have sufficient privileges for PR 3212 in repo microsoft/microsoft-ui-xaml |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…gle one between all solutions.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We are running into some unexplained build pipeline issues. Hopefully once that goes though you will be able to merge master and avoid these build breaks. |
|
@azchohfi The pipeline fix just went in, could you please merge master into this PR? |
|
Absolutely! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The tests are all passing on 19H1. But they are failing on RS5 and lower. Looks like a crash in AppTestAutomationHelpers.dll. My guess is that we are calling an api that was adding only in 19H1, and we need to include some platform version checks. |
|
@kmahone or @StephenLPeters, could you please trigger a new build? I think it should be fine now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmahone
approved these changes
Sep 10, 2020
7 tasks
| { | ||
| InstallCert(Path.Combine(deploymentDir, packageName + ".cer")); |
There was a problem hiding this comment.
I think this may have broke the release pipeline because the cert file wasn't found
ghost
pushed a commit
to CommunityToolkit/WindowsCommunityToolkit
that referenced
this pull request
Oct 16, 2020
WCT is now sharing WinUI's test infrastructure. This is the continuation of the work on this PR microsoft/microsoft-ui-xaml#3212. ## PR Type What kind of change does this PR introduce? - Feature - Build or CI related changes ## What is the current behavior? No UI Tests. ## What is the new behavior? Added simple UI Tests for the WCT that use the same shared infrastructure used by WinUI. This will enable us to move controls/helpers in an easier way from the WCT->WinUI in the future. ## PR Checklist Please check if your PR fulfills the following requirements: - [X] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets) - [X] Tests for the changes have been added (for bug fixes / features) (if applicable) - [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [X] Contains **NO** breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work refactors MUX's test infrastructure and decouples it into an easier to use nuget package that can be leveraged by other app developers (e.g. the Windows Community Toolkit) to create tests that build for both MSTest and TAEF.
This PR now generates 3 new nuget packages:
Motivation and Context
Share UI test infra structure with WCT, to make it easier to move a control from the WCT to WinUI.
How Has This Been Tested?
Both on MUX (both running TAEF tests locally and MSTest thru VS 16.7) and on the WCT (https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/muxtestinfra)